Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reset_step_count #175

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Add reset_step_count #175

merged 1 commit into from
Mar 24, 2025

Conversation

sarsko
Copy link
Contributor

@sarsko sarsko commented Mar 21, 2025

Adds reset_step_bound.

Main motivation is to be able to scale up tests without having a huge step bound.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sarsko sarsko force-pushed the reset branch 2 times, most recently from 250ad11 to a7112bb Compare March 21, 2025 18:22
Copy link
Member

@jorajeev jorajeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No unit test?

@sarsko sarsko force-pushed the reset branch 2 times, most recently from dab0eaa to 1d2ba70 Compare March 21, 2025 20:41
@sarsko sarsko dismissed jorajeev’s stale review March 21, 2025 20:41

Tests added

@sarsko sarsko force-pushed the reset branch 2 times, most recently from 3ed7ec7 to d94890f Compare March 24, 2025 10:11
@sarsko sarsko force-pushed the reset branch 2 times, most recently from 530a8b8 to 4f9b0c0 Compare March 24, 2025 10:16
@sarsko sarsko changed the title Add reset_step_bound Add reset_step_count Mar 24, 2025
bkragl
bkragl previously approved these changes Mar 24, 2025
bkragl
bkragl previously approved these changes Mar 24, 2025
@sarsko
Copy link
Contributor Author

sarsko commented Mar 24, 2025

cargo fmt accidentally moved the import of the DfsScheduler under the comment about the atomics, so this push fixes that.

@sarsko sarsko enabled auto-merge (squash) March 24, 2025 10:59
@sarsko sarsko merged commit 4129ea8 into main Mar 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants